Don't add basic route to the router map #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -258,6 +258,14 @@ describe('Acceptance: ember generate', function() { | |||
| }); | |||
| }); | |||
|
|
|||
| it('route basic isn\'t added to router', function() { | |||
| return generate(['route', 'basic']).then(function() { | |||
| assertFile('app/router.js', { | |||
There was a problem hiding this comment.
Can you add an assertion to confirm that app/routes/basic.js was created too? I know it is, I'd just like this test to be clear that we are creating the file, but not injecting into router.js...
rwjblue
added a commit
that referenced
this pull request
Jul 16, 2014
Don't add basic route to the router map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The route name
basicis reserved and will be used for all generated routes, and should never be used in the Router map. This makes sure it isn't added when runningember generate route basic.