Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Addons to provide blueprints. #1222

Merged
merged 2 commits into from
Jul 2, 2014
Merged

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Jul 1, 2014

Replaces #1088.

All of the hard work was done by @manuelmitasch, I rebased and updated per the last few tweaks needed for completion.

Manuel Mitasch and others added 2 commits July 1, 2014 19:05
This allows blueprints from addons to have access to all of the internal
inherited functions from the EmberCLI `Blueprint` class without having
to have `ember-cli` as a dependency.

Also, make `addon.blueprintPaths` a function.
@rwjblue
Copy link
Member Author

rwjblue commented Jul 1, 2014

I believe that this is good to go now.

@jgwhite - Would you review (you are likely the most familiar with the Blueprint code)?

@jgwhite
Copy link
Contributor

jgwhite commented Jul 2, 2014

This looks awesome. LGTM.

@manuelmitasch
Copy link
Contributor

Thanks for bringing this over the finish line.
Removing the dependency on ember-cli from within blueprint addons is a great idea.

I will publish my rest-api blueprint today, which can guide as a first example.

rwjblue added a commit that referenced this pull request Jul 2, 2014
Allow Addons to provide blueprints.
@rwjblue rwjblue merged commit 515fb35 into ember-cli:master Jul 2, 2014
@manuelmitasch
Copy link
Contributor

I have published my rest-api blueprint to npm + github:
https://github.com/manuelmitasch/ember-cli-rest-api-blueprint

@rwjblue rwjblue deleted the blueprints branch July 2, 2014 11:06
@millisami
Copy link

This might not be the right place to put it, but since i couldn't find any better place, I'm adding it here.

I wanted to build an ember-addon for pagination. So, what would be the command to scaffold this new addon? i.e. like ember addon new pagination

Is there anything published like this?

@rwjblue
Copy link
Member Author

rwjblue commented Jul 24, 2014

@millisami - There is no blueprint for addons at the moment. This is definitely something that is on the roadmap, but we are still solidifying the way we want things structured before embedding it.

@millisami
Copy link

@rwjblue Glad to hear its in the radar!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants