Adds improved ember build --watch and tests.
#1131
Conversation
| } | ||
| } | ||
| }) | ||
| .catch(function() { |
There was a problem hiding this comment.
Lets remove this unused catch (or use it).
There was a problem hiding this comment.
Perhaps the catch is needed because of the process.kill (if that is why, can you just leave a small comment)?
|
This is exactly what I was envisioning! Sorry for not being clearer on the earlier feedback, but I'm very happy with how this has progressed. I left a handful of notes (small things), and we definitely will need an entry in the CHANGELOG for this. Happy to merge once those things are squared away. |
can't have that!
v0.0.1 had the problem of displaying fail image for both fail and success case.
Prior to this change, only the first item in the directory would be removed (oops).
* Refactors express server to explicitly start the http server. This was what it does naturally, but we need access to the raw server to be able to teardown the server between tests. * Refactor express server to make it a bit more testable. * Add `addon.serverMiddleware` callback function. The addon is called with the instance of the express app. * Refactor `api-stub` blueprint (and expected API) so that the express app is started in a consistent way. Prior to this, if you had a `./server/` folder, your code would create the `express` app add the `ember-cli` middleware.
Updated CHANGELOG for PR [ember-cli#1117](ember-cli#1117)
* options.watch => --watch flag, which is false by default. * Build command chooses the task based on options.watch. * Watch Task is in build-watch.js. * Unit test in cli-test.js verifies that watch option is passed correctly. * Acceptance test in smoke-test-slow.js, verifies that changes to file are written to rebuilt file by --watch.
|
Ok will make the changes and update. |
|
Generally speaking you do not need to close and open a new PR to update one that you have already submitted. Just make your changes, use |
|
Thanks, I'll definitely keep this in mind for future PRs! |
This is
ember build --watchtake 3.are written to rebuilt file by --watch.