Allow passing customHash in fingerprint options #1024
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
customHash
option that can be passed to the fingerprint configuration:The result is that fingerprinted files will use the
customHash
string instead of a MD5 hash of the file. (e.g. "assets/vendor-5429f75166356b28c3e42dd401abaf36.js" becomes "assets/vendor-custom123.js").The motivation behind this is that it's difficult to get the names of fingerprinted files if you aren't using the ember-cli generated dist/index.html file. By using
customHash
, you can set the fingerprint to be something like the current commit's SHA if you are working in a git repo or a version number from a package.json file. Those are easier to predict and setup in a non ember-cli generated index.html template elsewhere.It relies on some new functionality released in broccoli-asset-rev 0.0.6.