Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User can proceed with an another seed phrase during keycard backup #22013

Open
VolodLytvynenko opened this issue Feb 3, 2025 · 1 comment · May be fixed by #22252
Open

User can proceed with an another seed phrase during keycard backup #22013

VolodLytvynenko opened this issue Feb 3, 2025 · 1 comment · May be fixed by #22252
Assignees
@Parveshdhull
Labels
keycard mobile-core

Comments

@VolodLytvynenko
Copy link
Contributor

Follow up for #21990

Preconditions:

Case 1: The current user is restored via seed phrase
Case 2: The current user is restored via key card

Steps:

  1. Go profile
  2. Keykard -> manage key cards -> scan Empty Key Card
  3. Navigate to seed phrase entering page
  4. Enter seed that does not belong to the current restored user

Actual result:

The user is allowed to proceed further despite entering an incorrect seed phrase.

wrong_seed_kk.mp4

Expected result:

The message "The phrase you’ve entered not matching key pair that you want to back up" validation is shown

https://www.figma.com/design/YGm3igIOAcwMqUVJWCJ6f1/Keycard?node-id=3572-73684&t=cyttCtdwjsDdQrG5-0

OS:

IOS, Android

Devices:

  • Pixel 7a, Android 13
  • iPhone 11 Pro Max, IOS 17

ENV:

Nightly 3 Feb, 2025
@VolodLytvynenko VolodLytvynenko added this to the 2.32.0 milestone Feb 3, 2025
@VolodLytvynenko VolodLytvynenko mentioned this issue Feb 3, 2025
Merged
@flexsurfer flexsurfer mentioned this issue Feb 3, 2025
Closed
@churik churik modified the milestones: 2.32.0, 2.33.0 Feb 4, 2025
@VolodLytvynenko VolodLytvynenko changed the title User can proceed with an incorrect seed phrase during keycard backup User can proceed with an another seed phrase during keycard backup Feb 5, 2025
@churik
Copy link
Member

churik commented Mar 6, 2025

better to revise in scope of grooming of all keycard-related issues, I’m excluding it from the milestone in favor of higher-priority items.

@churik churik removed this from the 2.33.0 milestone Mar 6, 2025
@flexsurfer flexsurfer linked a pull request Mar 6, 2025 that will close this issue
Open
@Parveshdhull Parveshdhull self-assigned this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Parveshdhull Parveshdhull

Labels
keycard mobile-core
Projects
Status Desktop/Mobile Board
Status: Next
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Error Handling Logic in Enter Seed Phrase Screen status-im/status-mobile
3 participants
@churik @Parveshdhull @VolodLytvynenko