Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve keycard on-card-connected-event-vector #21971

Closed
Parveshdhull opened this issue Jan 22, 2025 · 4 comments
Closed

Improve keycard on-card-connected-event-vector #21971

Parveshdhull opened this issue Jan 22, 2025 · 4 comments

Comments

@Parveshdhull
Copy link
Member

Parveshdhull commented Jan 22, 2025

Summary

For the keycard, we need to add events to the on-card-connected-event-vector so that we can re-dispatch them when the keycard is reconnected. I believe this applies to all keycard events, not just :keycard/create.start.

We need to establish a proper flow for adding re-dispatchable events and cleaning them up once they are completed. Currently, we are not cleaning up old stored events (as mentioned in #21918), which results in them being dispatched again when the card is reconnected.

cc @flexsurfer Please feel free to take this issue, or I can address it after #21970.

@Parveshdhull Parveshdhull changed the title Cleanup keycard on-card-connected-event-vector Improve keycard on-card-connected-event-vector Jan 22, 2025
@flexsurfer
Copy link
Member

i think it's not a bug, that's how it works, on-card-connected-event-vector should be the same it used when keycard lost connection, :keycard/create.start. is a special case, which should be addressed separately

@Parveshdhull
Copy link
Member Author

Thank you @flexsurfer for your comment. I see now :keycard/connectand:keycard/disconnectto maintainon-card-connected-event-vector`'s lifecycle.

@flexsurfer
Copy link
Member

thanks @Parveshdhull here #21969 flow has been updated so we could fix all issues in this task

@Parveshdhull
Copy link
Member Author

replaced by #22017 (more details)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants