-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve keycard on-card-connected-event-vector #21971
Comments
i think it's not a bug, that's how it works, on-card-connected-event-vector should be the same it used when keycard lost connection, |
|
thanks @Parveshdhull here #21969 flow has been updated so we could fix all issues in this task |
replaced by #22017 (more details) |
Summary
For the keycard, we need to add events to the on-card-connected-event-vector so that we can re-dispatch them when the keycard is reconnected. I believe this applies to all keycard events, not just :keycard/create.start.
We need to establish a proper flow for adding re-dispatchable events and cleaning them up once they are completed. Currently, we are not cleaning up old stored events (as mentioned in #21918), which results in them being dispatched again when the card is reconnected.
cc @flexsurfer Please feel free to take this issue, or I can address it after #21970.
The text was updated successfully, but these errors were encountered: