You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
No error is shown when signing the event when user's network differs from event network.
For typed data, we check if the chainId inside the data is the same as the session-request chainId (for security reasons) and if they're different, the signing will fail. We should show an error telling the user that it failed and the reason.
If there is no chainId in the typeddata, we assume it's not chain specific and it should pass successfully (fixed here).
cc: @xAlisher we will need an extra toast during typeddata signing requests
Actual result: no error after signing the request. In fact the request is not signed as it is triggered on Mainnet while user is on testnet.
Also, the same actual result happens when I am trying to sign eth_signTypedData_v4 request while being connected on Mainnet (Ethereum + Optimism networks) and triggering request on Optimism
Expected result: we should show an error toast informing user that request has not been signed because user's network differs from request network.
No error is shown when signing the event when user's network differs from event network.
For typed data, we check if the chainId inside the data is the same as the session-request chainId (for security reasons) and if they're different, the signing will fail. We should show an error telling the user that it failed and the reason.
If there is no chainId in the typeddata, we assume it's not chain specific and it should pass successfully (fixed here).
cc: @xAlisher we will need an extra toast during typeddata signing requests
Steps:
Actual result: no error after signing the request. In fact the request is not signed as it is triggered on Mainnet while user is on testnet.
Also, the same actual result happens when I am trying to sign eth_signTypedData_v4 request while being connected on Mainnet (Ethereum + Optimism networks) and triggering request on Optimism
Expected result: we should show an error toast informing user that request has not been signed because user's network differs from request network.
Originally posted by @pavloburykh in #20693 (comment)
The text was updated successfully, but these errors were encountered: