Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collectibles: Hide account switcher in send flow #20472

Closed
J-Son89 opened this issue Jun 14, 2024 · 3 comments · Fixed by #20892
Closed

Collectibles: Hide account switcher in send flow #20472

J-Son89 opened this issue Jun 14, 2024 · 3 comments · Fixed by #20892
Assignees
Labels
feature feature requests medium-prio wallet-core Issues for mobile wallet team

Comments

@J-Son89
Copy link
Contributor

J-Son89 commented Jun 14, 2024

It might be good to fix this together with #20479

The account switcher in the collectibles account flow makes things a bit more complicated.

We should hide the account switcher when we know the user is trying to send a collectible.

For example here is one screen where it can cause this issue:

Please consider other entry points to the sending flow. when verifying this feature works.

@ulisesmac
Copy link
Contributor

@J-Son89

Another options are:

  1. To keep the account switcher, but make it unpressable
  2. [I'd prefer this one] Make the account switcher pressable, but show only one account to switch:
    Example:

    Show the bottom sheet with only one option instead of two

My main concern with removing the account switcher is that it helps to know the account the user is using to send assets. Also I think it's better to keep consistent designs, some users may wonder why the account switcher disappeared.

wdyt?

@ulisesmac
Copy link
Contributor

@J-Son89

Another options are:

1. To keep the account switcher, but make it unpressable

2. [I'd prefer this one] Make the account switcher pressable, but show only one account to switch:
   Example:
   <img alt="" height="600" src="https://private-user-images.githubusercontent.com/90291778/348396723-9a18678a-b1d0-41b4-9dff-ed47ebdfadca.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE3NzQwNzksIm5iZiI6MTcyMTc3Mzc3OSwicGF0aCI6Ii85MDI5MTc3OC8zNDgzOTY3MjMtOWExODY3OGEtYjFkMC00MWI0LTlkZmYtZWQ0N2ViZGZhZGNhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIzVDIyMjkzOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVkZmQ5Nzk3MTdjOWZiZjAzYTUxZjA0NTRjYzg3YTg4MjJiMDAxZGJiNzEwYjlmOTJlNjMwOGNlOWQ4ZTg4N2UmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.b7npntOJD_rrmyKdK8S0MGWDqfN9Oqy96Nnt5Q-5oUc">
   Show the bottom sheet with only one option instead of two

My main concern with removing the account switcher is that it helps to know the account the user is using to send assets. Also I think it's better to keep consistent designs, some users may wonder why the account switcher disappeared.

wdyt?

This has been discused with the design team. The decision is to remove the account switcher, as the issue says

@J-Son89
Copy link
Contributor Author

J-Son89 commented Jul 23, 2024

Thanks @ulisesmac !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests medium-prio wallet-core Issues for mobile wallet team
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants