Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Group chat] Add new member after typing message and pressing enter #8349

Open
noeliaSD opened this issue Nov 21, 2022 · 5 comments · May be fixed by #17014
Open

[Group chat] Add new member after typing message and pressing enter #8349

noeliaSD opened this issue Nov 21, 2022 · 5 comments · May be fixed by #17014
Assignees
@jrainville
Labels
core-team Design-QA E:Desktop Chat Messages & Chat Features
Milestone
2.33.0 Beta

Comments

@noeliaSD
Copy link
Contributor

Description

Implement the new use case agreed with design team related to group chat:

  1. The group chat is setup
  2. The user adds a new member but doesn't hit the Confirm button
  3. When the user types another message and hits enter, the new member would be added and would receive the message and the To input and controls would disappear.
@noeliaSD
Copy link
Contributor Author

Here a task to cover the new use case agreed with @benjthayer. @benjthayer could you provide designs for that or add more details on it, if necessary?

Thanks

@noeliaSD noeliaSD added E:Groups and removed S:2 labels Nov 21, 2022
@benjthayer
Copy link

benjthayer commented Nov 21, 2022 •
edited by jrainville
Loading

Thanks @noeliaSD ! This flow would just replicate what we have in chat creation.

Functionality/behaviour we have recently added for chat/group chat creation:
When the user types a message, any recipients that are currently added as lozenges in the To input (prior to the user hitting the Confirm button) are added to the chat - at the same time the To input and Confirm and Cancel buttons are removed.

We need to add this same functionality for editing chat members. In the screen recording, when 'Julia' is added to the chat and a message is sent before the Confirm button is hit, Julia should be added as a member to the chat, receive the message and the To input and Confirm and Cancel buttons should be removed.

EditGroupMembers.mov

@iurimatias iurimatias added this to the 2.28.0 Beta milestone Feb 5, 2024
@alexjba alexjba assigned alexjba and unassigned alexjba Feb 9, 2024
@iurimatias
Copy link
Member

moved to 2.29 due to lack of space in this milestone

@iurimatias iurimatias modified the milestones: 2.28.0 Beta, 2.29.0 Beta Feb 16, 2024
@noeliaSD noeliaSD self-assigned this Apr 16, 2024
@noeliaSD
Copy link
Contributor Author

Assigned to myself to better analyse it!

@noeliaSD noeliaSD removed their assignment May 7, 2024
@noeliaSD noeliaSD modified the milestones: 2.29.0 Beta, 2.31.0 Beta May 7, 2024
@noeliaSD
Copy link
Contributor Author

noeliaSD commented May 7, 2024

Moved to 2.31 since in 2.30 the UI-team will be focused on wallet.

@jrainville jrainville modified the milestones: 2.31.0 Beta, 2.32.0 Beta Aug 26, 2024
@jrainville jrainville modified the milestones: 2.32.0 Beta, 2.33.0 Beta Dec 4, 2024
@jrainville jrainville self-assigned this Dec 30, 2024
@jrainville jrainville moved this from Next to In Progress in Status Desktop/Mobile Board Dec 30, 2024
jrainville added a commit that referenced this issue Dec 30, 2024
@jrainville
feat(group): enable updating the group members while sending a message
0487ddc 
Fixes #8349

When the member selector menu is open, sending a message adds/removes the members and then sends the message. Therefore, the new member will also receive the message.
@jrainville jrainville linked a pull request Dec 30, 2024 that will close this issue
Open
3 tasks
@jrainville jrainville moved this from In Progress to Code Review in Status Desktop/Mobile Board Dec 30, 2024
jrainville added a commit that referenced this issue Dec 31, 2024
@jrainville
feat(group): enable updating the group members while sending a message
3fb89d6 
Fixes #8349

When the member selector menu is open, sending a message adds/removes the members and then sends the message. Therefore, the new member will also receive the message.
jrainville added a commit that referenced this issue Jan 3, 2025
@jrainville
feat(group): enable updating the group members while sending a message
0702919 
Fixes #8349

When the member selector menu is open, sending a message adds/removes the members and then sends the message. Therefore, the new member will also receive the message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrainville jrainville

Labels
core-team Design-QA E:Desktop Chat Messages & Chat Features
Projects
Status Desktop/Mobile Board
Status: Code Review
Milestone
2.33.0 Beta
Development

Successfully merging a pull request may close this issue.

Add new member after typing message and pressing enter status-im/status-desktop
5 participants
@iurimatias @jrainville @alexjba @noeliaSD @benjthayer