Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmbarkSpec & deployAll are not supported anymore, breaking tests #9

Open
oskarth opened this issue Jun 26, 2018 · 1 comment
Open
Assignees

Comments

@oskarth
Copy link

oskarth commented Jun 26, 2018

With git checkout 000-snt-voting-dapp there appears to be some tests that are deprecated using Embark 3.1.2:

embark test
...
EmbarkSpec & deployAll are not supported anymore
You can learn about the new revamped tests here: https://embark.status.im/docs/testing.html
> ag EmbarkSpec
test/controlled.js
9:            EmbarkSpec.deployAll(contractsConfig, async function(accounts) {

test/DelegationProxyTest.js
43:          EmbarkSpec.deployAll(contractsConfig, async function(accountsArr) {

test/erc20token.js
9:        EmbarkSpec.deployAll(contractsConfig, async function(accounts) {

test/testtoken.js
12:    EmbarkSpec.deployAll(contractsConfig, async function(accounts) {

test/minimetoken.js
27:    EmbarkSpec.deployAll(contractsConfig, async function(accountsArr) {

See embarklabs/embark#548

Acceptance criteria

Make embark test green again with latest version of Embark.

@oskarth
Copy link
Author

oskarth commented Jun 26, 2018

Problem does not on seem to appear on master

> git checkout master
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
> ag EmbarkSpec

EDIT: Ah, appears master doesn't use Embark yet?

> embark test
Compiling contracts
Cannot find file embark.json Please ensure you are running this command inside the Dapp folder
Cannot find file embark.json Please ensure you are running this command inside the Dapp folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants