Section Fieldtype should not be listable #2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 14, 2020
|
Awesome. Normally I'd say no to this because there's section-specific stuff out in odd places, but it'll be ok for now. We planned to introduce "ui fields" that the section fieldtype would fall under. We can move the code around when we do that. 🤘 |
|
Wow awesome job @damcclean. UI fields sound cool @jasonvarga. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes it so fields with the
Sectionfieldtype should no longer be listable or appear as columns anywhere in the CP.Changes
If a field is has the type of
section, it will no longer be listable and will no longer show as as column when you click the 'column dropdown' on the collection entries listing page.When a user adds/updates a section field in the Fieldset/Blueprint builder, they will no longer see the option to configure if it's listable or not. I thought it would make sense to hide/remove this option as we override it anyway in the
Fieldclass.Related Issues
It fixes #2117 and fixes #2013.