Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Fix styling issues with the save-button-options component #10464

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

duncanmcclean
Copy link
Member

@duncanmcclean duncanmcclean commented Jul 16, 2024

This pull request fixes an issue with the save-button-options component, where the Radio buttons were huge, after its recent refactoring in #10453.

The CSS to set the height/width of the icon was relying on a class automatically added to fields in publish forms. However, it wasn't there in the save buttons component, causing the huge icons.

This PR also adds a smidge of padding at the top and bottom of the radio buttons, to add some additional spacing, like it had before the recent refactor.

Before

CleanShot 2024-07-16 at 15 55 09

After

CleanShot 2024-07-16 at 15 49 50

@jasonvarga jasonvarga merged commit f39de28 into 5.x Jul 16, 2024
17 checks passed
@jasonvarga jasonvarga deleted the fix/save-button-option-styles branch July 16, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants