Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Broken lightbox display modes #4643

Closed
cj12312021 opened this issue Mar 2, 2024 · 1 comment · Fixed by #4644
Closed

[Bug Report] Broken lightbox display modes #4643

cj12312021 opened this issue Mar 2, 2024 · 1 comment · Fixed by #4644
Labels
bug report Bug reports that are not yet verified

Comments

@cj12312021
Copy link
Collaborator

cj12312021 commented Mar 2, 2024

Describe the bug
Since #4569 was merged, the Lightbox no longer scales images appropriately to fit the screen (see: https://discordapp.com/channels/559159668438728723/644934273459290145/1213285460290314370). The full-screen button, as well as the different display modes, are also broken as a result of the change. Adding the max-height: 90vh; property will at least force the image to fit the screen and force the fit-to-screen option. However, this does not work for the other display modes. I don't use image clips, so it's unclear how or if those modes work with clips after that change, but I find it hard to believe they are.

@cj12312021 cj12312021 added the bug report Bug reports that are not yet verified label Mar 2, 2024
@cj12312021
Copy link
Collaborator Author

As I've been looking into this more, I see the issues I described in the original comment are only present when the lightbox is used to view images outside of the images page, so movie covers, performer images, or scrubber images. My hunch is that this is due to #4569 assuming all images used by the lightbox have weight and height property set. I suspect that is not the case for nonofficial images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Bug reports that are not yet verified
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants