fix(package): support alternative gradle module version syntax #6080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKatzwinkel
force-pushed
the
module-package-gradle
branch
from
271843c
to
78b741f
Compare
JKatzwinkel
force-pushed
the
module-package-gradle
branch
2 times, most recently
from
d4810f6
to
3857950
Compare
JKatzwinkel
force-pushed
the
module-package-gradle
branch
from
3857950
to
5cf9b98
Compare
davidkna
approved these changes
Jul 27, 2024
davidkna
changed the title
andytom
changed the title
|
Thank you for your contribution @JKatzwinkel and thanks for reviewing @davidkna. |
ekorchmar
pushed a commit
to ekorchmar/starship
that referenced
this pull request
Jul 30, 2024
…hip#6080) feat(package): support alternative gradle module version syntax (starship#6079)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I changed the regex in
src/modules/package.rs:113starship/src/modules/package.rs
Line 113 in 796a411
... so it matches lines like
... in addition to the syntax that was previously supported.
Motivation and Context
My Gradle projects use the version setting notation recommended in the documentation and I want the version to show up in my prompt.
Closes #6079
How Has This Been Tested?
Added a unit test and ran
cargo test --lib.Checklist: