install.sh doesn't clean up after installing or updating

[rvdm]

Current Behavior

When running install.sh, it creates a temporary archive as a target for the download. The target archive gets installed, but does not get removed afterwards.

Expected Behavior

temporary files get cleaned after installation was done

Additional context/Screenshots

n/a

Possible Solution

I think the fix is to do a check of the existence of the archive (and/or any result from unpacking) and to remove that file before returning. This can either be done in the install() function or in the main loop.

Environment

• Starship version: 1.19.0
• zsh version: zsh 5.8 (x86_64-debian-linux-gnu)
• Operating system: Debian 11.0.0
• Terminal emulator: iTerm2 3.4.19
• Git Commit Hash:
• Branch/Tag: master
• Rust Version: rustc 1.78.0 (9b00956e5 2024-04-29)
• Rust channel: release
• Build Time: 2024-05-15 17:09:04 +00:00

All of the above is one of my starship installs. I reproduced this on all of my linux machines.

Relevant Shell Configuration

n/a