Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click to download link TOML doesn't work for Nerd Font Symbols Preset #6063

Open
poorvaja-s-hub opened this issue Jul 1, 2024 · 4 comments
Assignees
Labels
🐛 bug Something isn't working as expected. 🌱 good first issue Good first issue to get your feet wet.

Comments

@poorvaja-s-hub
Copy link

Current Behavior

When I try to download the Nerd Font Symbols Preset from the website using the "Click to download" link at https://starship.rs/presets/nerd-font, the link does not work. Clicking on the link does nothing.

Expected Behavior

Clicking on the "Click to download" link should start the download of the Nerd Font Symbols Preset file.

Screenshots:

Screenshot 2024-07-02 at 01 28 22 Screenshot 2024-07-02 at 01 37 29
@poorvaja-s-hub poorvaja-s-hub added the 🐛 bug Something isn't working as expected. label Jul 1, 2024
@tnagatomi
Copy link

To add to that, all Presets' TOML download links seem to be broken, not just for Nerd Font Symbols Preset.

@davidkna
Copy link
Member

davidkna commented Aug 27, 2024

As a workaround, copying the download URL and pasting it into the address bar seems to work. Adding download to the <a /> tags may fix this.

@matchai matchai added the 🌱 good first issue Good first issue to get your feet wet. label Aug 27, 2024
@zaira-bibi
Copy link

Hi! I would like to work on this issue.

@zaira-bibi
Copy link

zaira-bibi commented Aug 29, 2024

SOLUTION:

I have added the download attribute to the markdown links (as mentioned by @davidkna) and now the link works. I will fix all the download TOML links and then create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working as expected. 🌱 good first issue Good first issue to get your feet wet.
Projects
None yet
Development

No branches or pull requests

5 participants