Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass get-starknet to StarknetWalletProvider #37

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

yairans-starkware
Copy link
Contributor

@yairans-starkware yairans-starkware commented Feb 14, 2023

Description of the Changes

Depends on https://github.com/starkware-industries/starkware-commons-js/pull/68


Checklist

  • Manually tests of the main Application flows are done and passed.
  • New unit / functional tests have been added (whenever applicable).
  • Docs have been updated (whenever relevant).
  • PR title is follow the Conventional Commits convention: <type>[optional scope]: <description>, e.g: fix: prevent racing of requests

@netlify
Copy link

netlify bot commented Feb 14, 2023

Deploy Preview for cairo-playground ready!

Name Link
🔨 Latest commit d31a9ff
🔍 Latest deploy log https://app.netlify.com/sites/cairo-playground/deploys/63ecadfbeae3700008527e8f
😎 Deploy Preview https://deploy-preview-37--cairo-playground.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 14, 2023

Deploy Preview for starknet-playground ready!

Name Link
🔨 Latest commit d31a9ff
🔍 Latest deploy log https://app.netlify.com/sites/starknet-playground/deploys/63ecadfb60c88d0008f8e3c9
😎 Deploy Preview https://deploy-preview-37--starknet-playground.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

dan-ziv
dan-ziv previously approved these changes Feb 14, 2023
@yairans-starkware yairans-starkware merged commit 76c706c into dev Feb 15, 2023
@yairans-starkware yairans-starkware deleted the get-starknet-as-param branch February 15, 2023 10:13
dan-ziv pushed a commit that referenced this pull request Feb 15, 2023
 ## [1.0.0-dev.3](v1.0.0-dev.2...v1.0.0-dev.3) (2023-02-15)

### 🧩 Features

* pass get-starknet to StarknetWalletProvider ([#37](#37)) ([76c706c](76c706c))
@dan-ziv
Copy link
Collaborator

dan-ziv commented Feb 15, 2023

🎉 This PR is included in version 1.0.0-dev.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants