-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: minor fixes in "Transaction lifecycle" #527
Conversation
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-527/documentation/ . |
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-527/documentation/ . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
* Update link to mailing list subscription (#512) * Update push.yml * Increase algolia hitsPerPage to 20 items (#509) * Increase algolia hitsPerPage to 20 items Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com> * minor fixes (#534) * minor fixes (#533) Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com> * minor fixes (#531) Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com> * docs: add Juno version information (#530) Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com> * minor fixes (#529) Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com> * minor fixes (#528) Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com> * fix: minor fixes in "L1-L2 messaging" (#532) * minor fixes * minor fixes --------- Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com> * fix: minor fixes in "Block structure" (#526) * minor fix * minor fix * minor fix --------- Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com> * fix: minor fixes in "Transaction lifecycle" (#527) * minor fix * minor fix * minor fix * minor fix --------- Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com> * fix: minor fixes in "Contract address" (#525) * minor fix * minor fix --------- Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com> * minor fix (#524) Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com> * minor fix (#523) Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com> * Add missing chain id to declare table (#490) --------- Co-authored-by: lorcan-codes <126797224+lorcan-codes@users.noreply.github.com> Co-authored-by: Raz Landau <125185051+LandauRaz@users.noreply.github.com> Co-authored-by: wojciechos <wojciech.zieba@gmail.com>
* Update link to mailing list subscription (#512) * Update push.yml * Increase algolia hitsPerPage to 20 items (#509) * Increase algolia hitsPerPage to 20 items Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com> * minor fixes (#534) * minor fixes (#533) Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com> * minor fixes (#531) Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com> * docs: add Juno version information (#530) Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com> * minor fixes (#529) Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com> * minor fixes (#528) Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com> * fix: minor fixes in "L1-L2 messaging" (#532) * minor fixes * minor fixes --------- Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com> * fix: minor fixes in "Block structure" (#526) * minor fix * minor fix * minor fix --------- Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com> * fix: minor fixes in "Transaction lifecycle" (#527) * minor fix * minor fix * minor fix * minor fix --------- Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com> * fix: minor fixes in "Contract address" (#525) * minor fix * minor fix --------- Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com> * minor fix (#524) Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com> * minor fix (#523) Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com> * Add missing chain id to declare table (#490) * Starknet UI fixes + more fixes (#537) * Fixes for starknet * do not center content, rather push left with padding * h2 spacing * doc left side more padding * table attempt to fix * max width increase * fix for centering admonitionblock * Addd padding to main content right to increase readability * Add spacing changes --------- Co-authored-by: JameStark <james@starkware.co> Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com> --------- Co-authored-by: lorcan-codes <126797224+lorcan-codes@users.noreply.github.com> Co-authored-by: Raz Landau <125185051+LandauRaz@users.noreply.github.com> Co-authored-by: wojciechos <wojciech.zieba@gmail.com> Co-authored-by: xgrizx <xxxgrizxxx@gmail.com>
Description of the Changes
Minor fixes in "Transaction lifecycle".
PR Preview URL
https://starknet-io.github.io/starknet-docs/pr-527/documentation/architecture_and_concepts/Blocks/transaction-life-cycle/
Check List
<docs/feat/fix/chore>(optional scope): <description>
, e.g:fix: minor typos in code
This change is