Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor fixes in "Transaction lifecycle" #527

Merged
merged 5 commits into from
Jun 9, 2023

Conversation

LandauRaz
Copy link
Collaborator

@LandauRaz LandauRaz commented Jun 7, 2023

Description of the Changes

Minor fixes in "Transaction lifecycle".

PR Preview URL

https://starknet-io.github.io/starknet-docs/pr-527/documentation/architecture_and_concepts/Blocks/transaction-life-cycle/

Check List

  • Changes have been done against dev branch, and PR does not conflict
  • PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

This change is Reviewable

@LandauRaz LandauRaz requested a review from JameStark June 7, 2023 14:37
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-527/documentation/ .

@LandauRaz LandauRaz changed the title fix: minor fixes in Transaction lifecycle fix: minor fixes in "Transaction lifecycle" Jun 7, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-527/documentation/ .

Copy link
Contributor

@JameStark JameStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@JameStark JameStark merged commit 872e18c into dev Jun 9, 2023
@JameStark JameStark deleted the razl/transaction_lifecycle branch June 9, 2023 08:33
JameStark added a commit that referenced this pull request Jun 9, 2023
* Update link to mailing list subscription (#512)

* Update push.yml

* Increase algolia hitsPerPage to 20 items (#509)

* Increase algolia hitsPerPage to 20 items

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>

* minor fixes (#534)

* minor fixes (#533)

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>

* minor fixes (#531)

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>

* docs: add Juno version information (#530)

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>

* minor fixes (#529)

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>

* minor fixes (#528)

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>

* fix: minor fixes in "L1-L2 messaging" (#532)

* minor fixes

* minor fixes

---------

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>

* fix: minor fixes in "Block structure" (#526)

* minor fix

* minor fix

* minor fix

---------

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>

* fix: minor fixes in "Transaction lifecycle" (#527)

* minor fix

* minor fix

* minor fix

* minor fix

---------

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>

* fix: minor fixes in "Contract address" (#525)

* minor fix

* minor fix

---------

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>

* minor fix (#524)

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>

* minor fix (#523)

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>

* Add missing chain id to declare table (#490)

---------

Co-authored-by: lorcan-codes <126797224+lorcan-codes@users.noreply.github.com>
Co-authored-by: Raz Landau <125185051+LandauRaz@users.noreply.github.com>
Co-authored-by: wojciechos <wojciech.zieba@gmail.com>
JameStark added a commit that referenced this pull request Jun 9, 2023
* Update link to mailing list subscription (#512)

* Update push.yml

* Increase algolia hitsPerPage to 20 items (#509)

* Increase algolia hitsPerPage to 20 items

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>

* minor fixes (#534)

* minor fixes (#533)

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>

* minor fixes (#531)

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>

* docs: add Juno version information (#530)

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>

* minor fixes (#529)

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>

* minor fixes (#528)

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>

* fix: minor fixes in "L1-L2 messaging" (#532)

* minor fixes

* minor fixes

---------

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>

* fix: minor fixes in "Block structure" (#526)

* minor fix

* minor fix

* minor fix

---------

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>

* fix: minor fixes in "Transaction lifecycle" (#527)

* minor fix

* minor fix

* minor fix

* minor fix

---------

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>

* fix: minor fixes in "Contract address" (#525)

* minor fix

* minor fix

---------

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>

* minor fix (#524)

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>

* minor fix (#523)

Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>

* Add missing chain id to declare table (#490)

* Starknet UI fixes + more fixes (#537)

* Fixes for starknet

* do not center content, rather push left with padding

* h2 spacing

* doc left side more padding

* table attempt to fix

* max width increase

* fix for centering admonitionblock

* Addd padding to main content right to increase readability

* Add spacing changes

---------

Co-authored-by: JameStark <james@starkware.co>
Co-authored-by: JameStark <113911244+JameStark@users.noreply.github.com>

---------

Co-authored-by: lorcan-codes <126797224+lorcan-codes@users.noreply.github.com>
Co-authored-by: Raz Landau <125185051+LandauRaz@users.noreply.github.com>
Co-authored-by: wojciechos <wojciech.zieba@gmail.com>
Co-authored-by: xgrizx <xxxgrizxxx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants