Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update validation info in transaction_lifecycle.adoc #1151

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

stoobie
Copy link
Collaborator

@stoobie stoobie commented Feb 26, 2024

Description of the Changes

Clarifying which type of validation is run on which type of transaction, and that the same validation is run during the mempool stage and the sequencer stage.

PR Preview URL

After you push a commit to this PR, a preview is built and a URL to the root of the preview appears in the comment feed.

Paste here the specific URL(s) of the content that this PR addresses.

Check List

  • Changes have been done against main branch, and PR does not conflict
  • PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

@stoobie stoobie requested review from odednaor and ArielElp February 26, 2024 12:29
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1151/documentation/ .

odednaor
odednaor previously approved these changes Feb 26, 2024
Copy link
Collaborator

@odednaor odednaor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

…twork_Architecture/transaction-life-cycle.adoc
@stoobie stoobie merged commit 2fc6bbf into main Feb 26, 2024
3 checks passed
@stoobie stoobie deleted the steve/tx_lifecycle/update_validation branch February 26, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants