[FlexiDag]Add read-write lock in dag db store #4101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanlee42
approved these changes
May 21, 2024
nkysg
reviewed
May 21, 2024
flexidag/src/blockdag.rs
Outdated
| header.id(), | ||
| ghostdata.selected_parent, | ||
| &mut merge_set, | ||
| ) { | ||
| ); | ||
| drop(reachability_writer); |
There was a problem hiding this comment.
maybe we don't need this drop. Please see this https://amanieu.github.io/parking_lot/parking_lot/struct.RwLock.html
Does not require any drop glue when dropped.
this is a demo from the above link.
use parking_lot::RwLock;
let lock = RwLock::new(5);
// many reader locks can be held at once
{
let r1 = lock.read();
let r2 = lock.read();
assert_eq!(*r1, 5);
assert_eq!(*r2, 5);
} // read locks are dropped at this point
// only one write lock may be held, however
{
let mut w = lock.write();
*w += 1;
assert_eq!(*w, 6);
} // write lock is dropped here
simonjiao
force-pushed
the
dag-master-db-reentrance
branch
from
5fe9c3e to
50b846a
Compare
nkysg
reviewed
May 22, 2024
flexidag/src/blockdag.rs
Outdated
|
|
||
| self.storage | ||
| .relations_store | ||
| .write() | ||
| .insert(real_origin, BlockHashes::new(vec![]))?; | ||
| // self.storage |
nkysg
reviewed
May 22, 2024
flexidag/tests/tests.rs
Outdated
| @@ -179,7 +258,7 @@ fn test_dag_genesis_fork() { | |||
| let _ghostdata = dag.ghostdata_by_hash(header.id()).unwrap().unwrap(); | |||
| } | |||
|
|
|||
| // fork, produce a new dag gensis | |||
| // // fork, produce a new dag gensis | |||
nkysg
approved these changes
May 22, 2024
simonjiao
force-pushed
the
dag-master-db-reentrance
branch
from
fe8358a to
b4960cc
Compare
…ock in dag commit procedure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information