Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dev]refactor StarcoinVM module remove mut StateViewCache #3911

Closed
nkysg opened this issue Jun 14, 2023 · 0 comments · Fixed by #3916
Closed

[Dev]refactor StarcoinVM module remove mut StateViewCache #3911

nkysg opened this issue Jun 14, 2023 · 0 comments · Fixed by #3916
Assignees
@welbon
Labels
enhancement Enhancement

Comments

@nkysg
Copy link
Collaborator

nkysg commented Jun 14, 2023 

    fn execute_user_transaction<S: StateView>(
        &mut self,
        txn: SignedUserTransaction,
        remote_cache: &mut StateViewCache<'_, S>,
    ) -> (VMStatus, TransactionOutput) {

these function StateViewCache use mut. we need to remove mut.
@nkysg nkysg added the enhancement Enhancement label Jun 14, 2023
@nkysg nkysg linked a pull request Jun 27, 2023 that will close this issue
[vm] StarcoinVM refactor remove mut reference for some functions #3916
Merged
7 tasks
@nkysg nkysg closed this as completed Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@welbon welbon

Labels
enhancement Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[vm] StarcoinVM refactor remove mut reference for some functions starcoinorg/starcoin
2 participants
@welbon @nkysg