Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Some test cases failed with the latest master code #3654

Closed
pause125 opened this issue Aug 14, 2022 · 3 comments
Closed

[Bug Report] Some test cases failed with the latest master code #3654

pause125 opened this issue Aug 14, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@pause125
Copy link
Collaborator

Bug Report

Starcoin version:

master latest, commit a991c9b

Current behavior:

Some test cases failed:

  • case1: thread 'unit_tests::access_path_test::test_access_path' panicked at 'access_path from str should ok: unrecognized token', vm/types/src/unit_tests/access_path_test.rs:86:73

  • case2: thread 'unit_tests::access_path_test::test_access_path_str_valid' panicked at 'assertion failed: (left == right)
    left: "0x00000000000000000000000000000001/1/0x00000000000000000000000000000001::Account::Account",
    right: "0x00000000000000000000000000000001/1/0x1::Account::Account"', vm/types/src/unit_tests/access_path_test.rs:29:9

Expected behavior:

The unit tests should pass.

Steps to reproduce:

  • case1: run cargo test --package starcoin-vm-types --lib -- unit_tests::access_path_test::test_access_path --exact --nocapture --ignored
  • case2: run cargo test --package starcoin-vm-types --lib -- unit_tests::access_path_test::test_access_path_str_valid --exact --nocapture

Related code:

Other information:

Related issues: #3651, #3652

@pause125 pause125 added the bug Something isn't working label Aug 14, 2022
@pause125
Copy link
Collaborator Author

@jiangying000 @JerryKwan

@jiangying000
Copy link
Collaborator

@jiangying000 @JerryKwan

I am trying to temporarily fix them in #3655, could be rollback when rolling short_str commit back

@jiangying000
Copy link
Collaborator

This should be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants