Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.3 pinned to dbt-core==1.0.3 #221

Closed
1 task done
colin-rogers-dbt opened this issue Feb 1, 2023 · 2 comments
Closed
1 task done

v1.0.3 pinned to dbt-core==1.0.3 #221

colin-rogers-dbt opened this issue Feb 1, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@colin-rogers-dbt
Copy link
Contributor

colin-rogers-dbt commented Feb 1, 2023

Expected behavior

dbt-trino is compatible with the latest . patch version of dbt-core (i.e. it uses dbt-core ~= 1.0.0 syntax in expressing requirements in it's setup.py file)

Actual behavior

setup.py in v1.0.3 pins to earlier 1.0 patch of dbt-core making it incompatible with later patch releases. The result is an unexpected downgrade from dbt-core==1.0.9-> dbt-core==1.03.

Steps To Reproduce

pip install dbt-core~=1.0.0 dbt-trino~=1.0.0

Log output/Screenshots

No response

Operating System

linux

dbt version

1.0.9

Trino Server version

N/A

Python version

3.9

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@colin-rogers-dbt colin-rogers-dbt added the bug Something isn't working label Feb 1, 2023
@leniartek
Copy link

Hi @colin-rogers-dbt
Issue is already fixed for dbt-core 1.1
dbt-core 1.0.x is not supported anymore, that's why I don't see a reason to fix this.

https://docs.getdbt.com/docs/dbt-versions/core
Screenshot 2023-02-02 at 12 02 04

@leniartek
Copy link

@colin-rogers-dbt We will fix this issue in order to clear the path for the future backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants