New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the `trino__get_merge_sql` macro #125

Open

1 task done

mdesmet opened this issue Sep 9, 2022 · 2 comments

Labels

Contributor

mdesmet commented Sep 9, 2022

Describe the feature

Following issues preventing us from using the default dbt merge macro:

Need to alias columns on WHEN not matched clause: MERGE when not matched should not require aliasing the column names in the VALUES clause trinodb/trino#14014
No support for WHEN false clause: SQL MERGE fails if ON condition is literal FALSE trinodb/trino#13751

Once these are resolved we should remove our macro override.

Describe alternatives you've considered

No response

Who will benefit?

No response

Are you willing to submit PR?

Yes I am willing to submit a PR!

The text was updated successfully, but these errors were encountered:

mdesmet added the enhancement label

Contributor

hovaesco commented Nov 7, 2022

It was most probably fixed by trinodb/trino#14650 and should be included in Trino 401.

Contributor

hovaesco commented Nov 23, 2022 •

edited

Loading

Related PR merged trinodb/trino#13926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment