Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance, and memory pressure of reactive.array #89

Open
NullVoxPopuli opened this issue Mar 29, 2023 · 1 comment
Open

Improve performance, and memory pressure of reactive.array #89

NullVoxPopuli opened this issue Mar 29, 2023 · 1 comment

Comments

@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Mar 29, 2023

@runspired has this performant version of TrackedArray, that should probably be the default: https://github.com/emberjs/data/blob/main/packages/store/src/-private/record-arrays/identifier-array.ts

Also, and maybe this is more the issue, is that we need to set up some benchmarks to keep in artifacts, so that on each PR, we can run "the benchmark", compare against what's on main, and ensure that things don't regress.

Would be good to set up after this lands: #86

And assigning myself, too -- j/k, can't 😅

@wycats
Copy link
Member

wycats commented Apr 18, 2023

@NullVoxPopuli We need to wait until we have prod mode to properly compare the two versions. But I'll take a look at the @runspired version and see if there's anything I can pull in in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants