Removes empty initialize methods: Style/RedundantInitialize: Remove unnecessary empty initialize method.

[dorianmariecom]

Before:

class A
  def initialize
    raise NotImplementedError
  end
end

class B < A
  def initialize
  end
end

puts B.new

After:

# frozen_string_literal: true

class A
  def initialize
    raise NotImplementedError
  end
end

class B < A
end

puts B.new

> standardrb -v
1.33.0

[al2o3cr]

This is also troublesome if the empty initialize takes arguments:

class A
  def initialize(not_used)
    # this space intentionally left blank
  end
end

a_variable_instead_of_some_kind_of_lookup = A

a_variable_instead_of_some_kind_of_lookup.new("foo")

Just had this happen on a client project.

[searls]

Makes sense 👍. Standard should be skeptical of any cop that runs the risk of screwing up the user's intended behavior, and it's clear there are too many uncovered edge cases for this cop to be acceptable.

In the future, it'd be helpful to link to the RuboCop docs and share Standard's current configuration (in this case: Style/RedundantInitialize and

Style/RedundantInitialize:
  Enabled: true

[jasonkarns]

Worth noting that this cop is not Safe per rubocop's metadata. I presume that we are less likely to enable cops that are not safe.

[czeise]

Worth noting that this cop is not Safe per rubocop's metadata. I presume that we are less likely to enable cops that are not safe.

Definitely. It looks like this particular cop wasn't initially marked as unsafe until this same issue was identified.

[dorianmariecom]

Thanks all