Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - Mute Button #194

Closed
Archdoog opened this issue Aug 24, 2024 · 4 comments · Fixed by #296
Closed

iOS - Mute Button #194

Archdoog opened this issue Aug 24, 2024 · 4 comments · Fixed by #296
Labels
good first issue Good for newcomers iOS prod onboarding blocker Blocks production deployment of a known target user

Comments

@Archdoog
Copy link
Collaborator

Add a mute button to iOS

@Archdoog Archdoog added iOS prod onboarding blocker Blocks production deployment of a known target user labels Aug 24, 2024
@ianthetechie ianthetechie added the good first issue Good for newcomers label Aug 27, 2024
@MarekSabol
Copy link
Contributor

Hi, I would like to take over this issue :)

@MarekSabol
Copy link
Contributor

Hi @Archdoog,

I started working on the implementation and I wanted to know if you have some preference on solution.

I adjusted file DemoNavigationView and created working button to mute and look like the rest of UI:
Snímka obrazovky 2024-10-06 o 14 37 14

image

If you agree with this I would then ask you to assign this issue to me and I will submit this solution.

Thank you so far :)

@ianthetechie
Copy link
Contributor

Nice!

I would first look at the Android code as it should be quite similar.

Basically make a SwiftUI mute button view (what you have looks about right!) in the SwiftUI target so it's reusable. Then add it to the default portrait and navigation overlays. I would suggest having it in the same location as Android which I think was upper right. You can se how we do other default views in the flexible grid layout.

Feel free to open up a PR (even a draft) and tag us for a review :)

@MarekSabol
Copy link
Contributor

Hi, sorry for late response, but this week was crazy :D, I've created PR IOS Mute button #294.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers iOS prod onboarding blocker Blocks production deployment of a known target user
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants