Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for signers-voting contract #4402

Closed
wants to merge 4 commits into from

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Feb 20, 2024

No description provided.

@obycode obycode requested a review from setzeus February 20, 2024 20:26
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (955ac33) 82.97% compared to head (1ec0ea2) 82.92%.
Report is 7 commits behind head on feat/4354-aggregate-key.

Files Patch % Lines
...src/chainstate/stacks/boot/signers_voting_tests.rs 98.21% 17 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           feat/4354-aggregate-key    #4402      +/-   ##
===========================================================
- Coverage                    82.97%   82.92%   -0.06%     
===========================================================
  Files                          448      448              
  Lines                       322151   323089     +938     
===========================================================
+ Hits                        267312   267906     +594     
- Misses                       54839    55183     +344     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@obycode
Copy link
Contributor Author

obycode commented Feb 21, 2024

Merged into #4360

@obycode obycode closed this Feb 21, 2024
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants