Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop at nakamoto block height #781

Merged
merged 11 commits into from
Nov 7, 2024
Merged

fix: stop at nakamoto block height #781

merged 11 commits into from
Nov 7, 2024

Conversation

djordon
Copy link
Collaborator

@djordon djordon commented Nov 6, 2024 •
edited
Loading

Description

Closes #778 and addresses part of #685.

Changes

  • Change the get_tenure return type to include the anchor block hash and anchor block height.
  • Make sure fetch_unknown_ancestors stops at the nakamoto start height.

Testing Information

I haven't updated the tests, so this will fail.

Checklist:

  • I have performed a self-review of my code

@djordon djordon added the sbtc signer binary The sBTC Bootstrap Signer. label Nov 6, 2024
@djordon djordon added this to the sBTC: Deposit ready milestone Nov 6, 2024
matteojug
matteojug reviewed Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@matteojug matteojug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce! So far LGTM

@djordon djordon marked this pull request as ready for review November 6, 2024 18:17
@djordon djordon self-assigned this Nov 6, 2024
matteojug
matteojug approved these changes Nov 7, 2024
View reviewed changes
@djordon djordon merged commit 0d52435 into main Nov 7, 2024
4 checks passed
@djordon djordon deleted the 778-fix-potential-multiple-mint-attempts branch November 7, 2024 14:46
@djordon djordon mentioned this pull request Dec 4, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteojug matteojug matteojug approved these changes

@Jiloc Jiloc Awaiting requested review from Jiloc

@cylewitruk cylewitruk Awaiting requested review from cylewitruk

Assignees

@djordon djordon

Labels
sbtc signer binary The sBTC Bootstrap Signer.
Projects
sBTC
Status: Done
Milestone
sBTC: Deposit ready
Development

Successfully merging this pull request may close these issues.

[Feature]: Fix potential multiple mint attempts
2 participants
@djordon @matteojug