Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move block observer testing stuff around #643

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

cylewitruk
Copy link
Member

Description

Writing some block observer tests and the file was getting a bit long, so I refactored out the test harness etc. to a separate file in testing like we do for the signer & coordinator.

Pulling this into a separate PR to make review easy.

Changes

95% organizational, the rest is just cargo fmt + clippy + some getters on the test harness since now the fields aren't directly accessible from tests in the "real" block observer file.

Testing Information

Nothing special, everything is as before.

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cylewitruk cylewitruk added sbtc signer binary The sBTC Bootstrap Signer. chore labels Oct 10, 2024
@cylewitruk cylewitruk added this to the sBTC MVP Code Complete milestone Oct 10, 2024
@cylewitruk cylewitruk self-assigned this Oct 10, 2024
Copy link
Collaborator

@djordon djordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✅

@cylewitruk cylewitruk merged commit 26fb558 into main Oct 10, 2024
4 checks passed
@cylewitruk cylewitruk deleted the chore/block-observer-testing-reorg branch October 10, 2024 12:40
@cylewitruk cylewitruk restored the chore/block-observer-testing-reorg branch October 15, 2024 09:17
@cylewitruk cylewitruk deleted the chore/block-observer-testing-reorg branch October 15, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore sbtc signer binary The sBTC Bootstrap Signer.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants