Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] duplicate check on create_deposit #1425

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[chore] duplicate check on create_deposit #1425

wants to merge 5 commits into from

Conversation

Jiloc
Copy link
Collaborator

@Jiloc Jiloc commented Feb 23, 2025 •
edited
Loading

Description

Closes: #518

Changes

  • return 200 if a copy of the deposit already exists.

Testing Information

  • added an integration test

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Jiloc Jiloc added emily API that communicates with Signers to trigger sBTC operations. chore labels Feb 23, 2025
@Jiloc Jiloc self-assigned this Feb 23, 2025
@Jiloc Jiloc marked this pull request as draft February 23, 2025 23:28
@Jiloc Jiloc marked this pull request as ready for review February 23, 2025 23:39
@Jiloc Jiloc added this to the sBTC: Withdrawal fine tuning milestone Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djordon djordon djordon left review comments

@matteojug matteojug Awaiting requested review from matteojug

@AshtonStephens AshtonStephens Awaiting requested review from AshtonStephens

@cylewitruk cylewitruk Awaiting requested review from cylewitruk

@MCJOHN974 MCJOHN974 Awaiting requested review from MCJOHN974

At least 1 approving review is required to merge this pull request.

Assignees

@Jiloc Jiloc

Labels
chore emily API that communicates with Signers to trigger sBTC operations.
Projects
sBTC
Status: In Review
Milestone
sBTC: Withdrawal fine tuning
Development

Successfully merging this pull request may close these issues.

[Feature]: Explicit duplicate deposit txid check is missing
2 participants
@Jiloc @djordon