Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] remove emily calls from signer's new_block handler #1421

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

Jiloc
Copy link
Collaborator

@Jiloc Jiloc commented Feb 23, 2025

Description

Part of #1067

Following #1409, the deposits and withdrawal updates will be sent to Emily only from the sidecar. In this PR we remove all calls to Emily from the new-block handler, that will now be only used to store the events in the DB.

Currently, the only update that the signers send to Emily is the Deposit Accepted. We should probably consider whether we want to remove it as well.

 

Changes

  • Remove Emily calls from signer's new_block
  • Adapt sbtc event handlers to only store the data and log the event.

Testing Information

  • Simplify new block unit tests
  • Remove the stacks_events_observer integration tests

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Jiloc Jiloc self-assigned this Feb 23, 2025
@Jiloc Jiloc added the sbtc signer binary The sBTC Bootstrap Signer. label Feb 23, 2025
@Jiloc Jiloc requested a review from cylewitruk February 23, 2025 23:15
@Jiloc Jiloc assigned matteojug and unassigned matteojug Feb 23, 2025
@Jiloc Jiloc requested review from matteojug and djordon February 23, 2025 23:15
Copy link
Collaborator

@djordon djordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@djordon
Copy link
Collaborator

djordon commented Feb 25, 2025

I think we can merge this because it doesn't resolve a ticket labeled as immunefi-scope. I think that we'd want to update the immunefi branch pretty soon (but not too soon) if this PR did resolve the ticket.

@Jiloc Jiloc added this to the sBTC: Withdrawal fine tuning milestone Feb 26, 2025
@Jiloc Jiloc added this pull request to the merge queue Feb 26, 2025
Merged via the queue into main with commit 8e555b2 Feb 26, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sbtc signer binary The sBTC Bootstrap Signer.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants