Skip to content
This repository has been archived by the owner on Dec 21, 2021. It is now read-only.

Validate repository URLs and warn about and ignore bad repositories #197

Closed
lfrancke opened this issue Jun 9, 2021 · 0 comments · Fixed by #262
Closed

Validate repository URLs and warn about and ignore bad repositories #197

lfrancke opened this issue Jun 9, 2021 · 0 comments · Fixed by #262
Assignees
@siegfriedweber
Labels
priority/medium type/enhancement New feature or request
Milestone
Release #1

Comments

@lfrancke
Copy link
Member

lfrancke commented Jun 9, 2021

Currently bad URLs will probably fail in get_repo_metadata when the URL is used for the first time.

That method currently has an expect with an empty string.

This issue contains two parts:

  1. Validate each repository URL once as soon as it is downloads the list of repositories (see cannot_be_a_base among other things)
  2. Just for completeness sake change the "expect" message to mention that/whay this can't fail
@lfrancke lfrancke added type/enhancement New feature or request priority/medium labels Jun 9, 2021
@lfrancke lfrancke added this to the Release #1 milestone Aug 9, 2021
@siegfriedweber siegfriedweber self-assigned this Aug 13, 2021
@siegfriedweber siegfriedweber mentioned this issue Aug 16, 2021
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@siegfriedweber siegfriedweber

Labels
priority/medium type/enhancement New feature or request
Projects
None yet
Milestone
Release #1
Development

Successfully merging a pull request may close this issue.

Validate repository URL eagerly stackabletech/agent
2 participants
@lfrancke @siegfriedweber