Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should exit non-zero following an exception #466

Open
captaincoordinates opened this issue Aug 8, 2024 · 0 comments
Open

Should exit non-zero following an exception #466

captaincoordinates opened this issue Aug 8, 2024 · 0 comments

Comments

@captaincoordinates
Copy link

Currently validation exits with a zero exit code if an exception occurs (e.g. connection reset by peer), potentially giving the false impression of a successful validation result.

__main__.py returns here. The returned int is ignored and the script completes normally.

I suggest __main__.py should instead call sys.exit(1) as it does in the case of validation errors.

I'm happy to submit a PR if you agree that this issue is worth addressing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant