-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get an error for a TODO without an expiration constraint #87
Comments
hey, its not yet possible. I think it would be a good idea though to optionally report invalid TODO comments. |
hmm thinking again about it.. most comments usually not have a expiration and forcing people to write a expiration condition sounds like a frustrating experience |
Why not making this an option disabled by default, to prevent it to break PhpStan if this behavior is not wanted? |
could you elaborate on how this "breaks phpstan"?
I can think of a project in which you really want a expire condition on every comment in the codebase. this sounds like a hurdle which might prevent people from commenting stuff at all |
Not on every comment, but on every todo comment ( |
Hello, great package!
I may have not searched correctly, but is there a way to get PhpStan fail with an error if a TODO exists without an expiration constraint?
For instance, if I write:
// TODO: write tests
I'd like to configure
phpstan-todo-by
in a way it will reject my TODO until I set a condition.Is it possible?
The text was updated successfully, but these errors were encountered: