-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Update KCC setup for private cluster #53
Conversation
…etting up of git-creds and root-sync. Updated anthos controller to be a private cluster. Added README file.
…configure-kcc-access.sh script. Updated README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it, please address my comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
well done
reminder for release-please to trigger, edit the commit message with proper suffix before merging, i.e.
feat: Update KCC setup for private cluster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm Borko!
editupdate: found them in the new 2nd script Issue is that the access script assumes rootsync usage - it leaves out the kpt optionI recommend we put the yakima service account role additions back to the generic setup script. |
. |
Changes:
setup-kcc.sh
:git-creds
androot-sync
. Since the config controller cluster is private, this cannot be done at this point. A bastion host / proxy needs to be first provisioned to enable connectivity to the cluster's private endpoint.