-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hydrate enhancement #27
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucstjean-ssc
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, amazing work @alaincormier-ssc!
davelanglois-ssc
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work alain!
davelanglois-ssc
pushed a commit
that referenced
this pull request
Apr 21, 2023
* feat: hydrate enhancement (#27) * add monorepo compatibility, error handling and option to automatically push changes * fix hydrate.sh linting * fix hydrate.sh linting * add logic in validate-yaml.sh to handle branch names * cleanup comments, add tests for certain conditions * handle multiple setters validation error within same directory * add set-upsteam to git push * cleanup comments, rename all functions with underscores for consistency * specify dir when running git status * chore(main): release 0.5.0 (#29) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Michael-McAuley-SSC
added a commit
that referenced
this pull request
Sep 22, 2023
* feat!: monorepo tagging solution implements the tagging solution when using monorepos. It completely overwrites the original tagging pipeline/script. * merge main into monorepo for hydrate enhancements v0.5.0 (#30) * feat: hydrate enhancement (#27) * add monorepo compatibility, error handling and option to automatically push changes * fix hydrate.sh linting * fix hydrate.sh linting * add logic in validate-yaml.sh to handle branch names * cleanup comments, add tests for certain conditions * handle multiple setters validation error within same directory * add set-upsteam to git push * cleanup comments, rename all functions with underscores for consistency * specify dir when running git status * chore(main): release 0.5.0 (#29) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Feat kpt tools (#42) * new tools * separating the inventory function than the doc generation * removed old code from inventory-controls.py * fix: linting * prettyfying * adding divider * new bind mount in docker compose * fix rm statement * fixing linting error in version-tagging.sh * cleaner script header * new comments * fixing comments * fixed bashrc * fix kpt instruction from generate docs * adressing comments * fix: results column in hydrate and kpt-push (#50) * fixed results column in hydrate and kpt-push * revert kpt version to 21 --------- Co-authored-by: alaincormier-ssc <94859304+alaincormier-ssc@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Michael <michael.mcauley2@ssc-spc.gc.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
key changes:
validate-yaml.yaml
andvalidate-yaml.sh
)