Starset Sarsaparilla #271
Merged
Starset Sarsaparilla #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteroidsOnSteroids
requested review from
DieselMohawk,
KeldWolf and
FluffMe
as code owners
github-actions
bot
added
S: Needs Review
|
RSI Diff Bot; head commit 1452738 merging into 43d9cdb Resources/Textures/_Harmony/Objects/Consumable/Drinks/starset-sarsaparilla.rsi
|
|
I'm gonna make a commit to change the color of the bottle sprite since that's off a bit |
Signed-off-by: SteroidsOnSteroids <161250813+SteroidsOnSteroids@users.noreply.github.com>
|
Okey dokey I think the sprites are good |
FluffMe
requested changes
Jan 6, 2025
Resources/Textures/_Harmony/Objects/Consumable/Drinks/sunset-soda.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/_Harmony/Objects/Consumable/Drinks/sunset-soda.rsi/meta.json
Outdated
Show resolved
Hide resolved
FluffMe
added
S: Awaiting Changes
Signed-off-by: SteroidsOnSteroids <161250813+SteroidsOnSteroids@users.noreply.github.com>
|
fixed I believe |
DieselMohawk
approved these changes
Jan 11, 2025
Me too, but considering most drinks have a blue outline regardless of the contents I tried to keep the sprite somewhat consistent with the rest of the drinks, may do another sprite update in the future |
github-actions
bot
added
S: Needs Review
|
Updated PR to uncomment the CL |
FluffMe
approved these changes
Jan 12, 2025
FluffMe
added a commit
that referenced
this pull request
Jan 12, 2025
ReboundQ3
pushed a commit
to ReboundQ3/Late-station-14
that referenced
this pull request
Jan 19, 2025
* sunset_spacesparilla * sunset_spacesparilla * Add files via upload Signed-off-by: SteroidsOnSteroids <161250813+SteroidsOnSteroids@users.noreply.github.com> * Update meta.json Signed-off-by: SteroidsOnSteroids <161250813+SteroidsOnSteroids@users.noreply.github.com> --------- Signed-off-by: SteroidsOnSteroids <161250813+SteroidsOnSteroids@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Added Starset Sarsaparilla to the list of beverages ingame
Why / Balance
I observed a serious lack of new vegas representation with the nuclear cola beverage so I took matters into my own hands
Technical details
Adds the starset sarsaparilla item, textures in the RSI, copyrights for those textures, and unique flavor for the beverage.
Media
Requirements
Breaking changes
No breaking changes.
Changelog
🆑