From b86a68f10ce38dd740a52f9ffe63365d304d698b Mon Sep 17 00:00:00 2001 From: sruusk Date: Mon, 27 Mar 2023 19:20:53 +0300 Subject: [PATCH] fix: Minor improvement to code --- src/player.ts | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/player.ts b/src/player.ts index e83e960..8818376 100644 --- a/src/player.ts +++ b/src/player.ts @@ -25,10 +25,6 @@ function getStat( throw new Error(`No ${statName} stat found`); } -function nullOrUndefined(value: any): boolean { - return value === null || value === undefined; -} - export async function getPlayer( this: EseaScraper, eseaProfileId: string | bigint @@ -115,8 +111,8 @@ export async function getPlayer( wins: wins, kills: kills, deaths: deaths, - rank: nullOrUndefined(profile.rank.placement_matches_remaining) ? profile.rank.current.rank : undefined, - mmr: nullOrUndefined(profile.rank.placement_matches_remaining) ? parseInt(profile.rank.current.mmr, 10) : undefined, + rank: !profile.rank.placement_matches_remaining ? profile.rank.current.rank : undefined, + mmr: !profile.rank.placement_matches_remaining ? parseInt(profile.rank.current.mmr, 10) : undefined, matches: totalGames, headshotRate: getStat(stats.stats, parseFloat, 'all.hs_percentage'), averageDamageRound: getStat(stats.stats, parseFloat, 'all.adr'),