Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve warning if model is missing a collision mesh #21

Open
srmainwaring opened this issue May 3, 2022 · 0 comments
Open

Improve warning if model is missing a collision mesh #21

srmainwaring opened this issue May 3, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@srmainwaring
Copy link
Owner

The hydrodynamics plugin assumes that all links of a model have a valid collision mesh. If the mesh is missing the plugin fails to load correctly but does not supply a very helpful warning.

Suggested behaviour:

  1. Either - ignore links with missing collision meshes
  2. Or - emit a better error and report which link(s) are missing collision meshes

It may also be worth emitting warnings when the collision mesh contains a large number of vertices or near degenerate triangles which will give rise to poor numerical behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant