Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return link of footnote not show after convert to pdf #1515

Closed
4 tasks done
lisongmin opened this issue Mar 17, 2020 · 6 comments
Closed
4 tasks done

Return link of footnote not show after convert to pdf #1515

lisongmin opened this issue Mar 17, 2020 · 6 comments
Labels
change request Issue requests a new feature or improvement

Comments

@lisongmin
Copy link

I checked that...

  • ... the documentation does not mention anything about my problem
  • ... the problem doesn't occur with the default MkDocs template
  • ... the problem is not in any of my customizations (CSS, JS, template)
  • ... there are no open or closed issues that are related to my problem

Description

return link of footnote not show after convert to pdf. It may be a css issue,
but I don't known how to fix it.

2020-03-17T23-34-06-screenshot

Expected behavior

The return link should show in pdf.

Actual behavior

Steps to reproduce the bug

  1. mkdocs build
  2. open site/pdf/combined.pdf

Package versions

  • Python: 3.8.0
  • MkDocs: 1.1
  • Material: 4.6.3
  • mkdocs-export-pdf-plugin: master branch

Project configuration

---
site_name: test

theme:
    name: material
    font: false

markdown_extensions:
    - footnotes
    - toc:
          slugify: !!python/name:pymdownx.slugs.uslugify

plugins:
    - pdf-export:
          combined: true

nav:
    - test.md

test.md

Footnotes[^1] have a label[^@#$%] and the footnote's content.

[^1]: This is a footnote content.
[^@#$%]: A footnote on the label: "@#$%".

System information

  • OS: archlinux
  • Browser: firefox
@squidfunk
Copy link
Owner

The return link is only shown, when the footnote is hovered or targeted, otherwise it is hidden. I don't know exactly how the PDF plugin works, but if it uses print styles, we could - in theory - display it. Are the other anchors clickable in the PDF? I never tried the export plugin.

@squidfunk
Copy link
Owner

Also note that this plugin adds custom CSS before printing:
https://github.com/zhaoterryy/mkdocs-pdf-export-plugin/blob/master/mkdocs_pdf_export_plugin/themes/material.py

As the plugin already customizes the CSS, please open an issue over at the plugin repository.

@lisongmin
Copy link
Author

The return link is only shown, when the footnote is hovered or targeted, otherwise it is hidden. I don't know exactly how the PDF plugin works, but if it uses print styles, we could - in theory - display it. Are the other anchors clickable in the PDF? I never tried the export plugin.

It is clickable, just not shown.

@lisongmin
Copy link
Author

Ok, i will open a new issue there, thanks.

@squidfunk
Copy link
Owner

As we're currently in the process of refactoring the theme, I checked the print styles and improved some of them in 71b2f5a. This should also fix the footnotes problem you mentioned. This fix will be part of the next major release. See #1498 for progress.

@squidfunk squidfunk added the change request Issue requests a new feature or improvement label Mar 17, 2020
@squidfunk squidfunk reopened this Mar 17, 2020
@squidfunk
Copy link
Owner

Released as part of RC 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change request Issue requests a new feature or improvement
Projects
None yet
Development

No branches or pull requests

2 participants