Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception when setting only logo icon in 5.0.0rc1 #1503

Closed
4 tasks done
frankie567 opened this issue Mar 11, 2020 · 4 comments
Closed
4 tasks done

Exception when setting only logo icon in 5.0.0rc1 #1503

frankie567 opened this issue Mar 11, 2020 · 4 comments
Labels
bug Issue reports a bug

Comments

@frankie567
Copy link

I checked that...

  • ... the documentation does not mention anything about my problem
  • ... the problem doesn't occur with the default MkDocs template
  • ... the problem is not in any of my customizations (CSS, JS, template)
  • ... there are no open or closed issues that are related to my problem

Description

In the configuration, when specifying a custom icon as logo, but not a custom repo icon, a jinja2.exceptions.TemplateNotFound is raised.

Expected behavior

The logo icon should be set, and the repo icon should fallback to the default.

Actual behavior

A jinja2.exceptions.TemplateNotFound is raised. As a workaround, we can set the repo icon the configuration.

Steps to reproduce the bug

  1. Start a mkdocs-material project
  2. Set this in the theme configuration:
theme:
  name: 'material'
  icon:
    logo: fontawesome/solid/microphone
  1. Run mkdocs serve

Package versions

  • Python: 3.7.5
  • MkDocs: 1.1
  • Material: 5.0.0rc1

Project configuration

site_name: FastAPI Users
site_description: Ready-to-use and customizable users management for FastAPI

theme:
  name: 'material'
  palette:
    primary: 'red'
    accent: 'red'
  icon:
    logo: fontawesome/solid/microphone
  favicon: 'favicon.png'

repo_name: frankie567/fastapi-users
repo_url: https://github.com/frankie567/fastapi-users
edit_uri: ""

markdown_extensions:
  - markdown_include.include:
      base_path: docs
  - toc:
      permalink: true
  - admonition
  - codehilite
  - pymdownx.superfences
  - pymdownx.tasklist

System information

  • OS: macOS 10.15.2
  • Browser: Chrome 80
@squidfunk squidfunk added the bug Issue reports a bug label Mar 11, 2020
@squidfunk
Copy link
Owner

Confirmed, thanks for reporting!

@squidfunk
Copy link
Owner

Fixed in fcbd47c, will be part of RC 2. We'll wait for some more feedback before the next RC, as this is a minor bug with a simple workaround for the time being.

@frankie567
Copy link
Author

That's great! Thanks @squidfunk 👍

@squidfunk
Copy link
Owner

Just released RC 2. Please re-open if the issue persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug
Projects
None yet
Development

No branches or pull requests

2 participants