-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Material 5.0.0 Status #1306
Comments
|
@wilhelmer nice idea 😁 I actually already thought about it. However, listening to the latest React Podcast with Kitze I learned that having a Donate button will probably not help you fund the work of your project. People don’t tend to donate for something that they can already use for free which is why I decided not to include one. |
Well you‘d get at least 1 pizza, better than nothing 😄 |
1 🍕 > 0 🍕 Yup, checks out. |
I started to document my progress regarding the rewrite of the current features in the original post. Furthermore I think I finally got the grasp of RxJS and boy, is it beautiful. If somebody has some experience with RxJS, I would really appreciate some comments on the architecture I'm building on the After migrating everything to RxJS, implementing instant loading (aka "turbolinks" which I prototyped three years (!) ago here) will be a breeze, as re-binding components will be super easy. This would also greatly improve search UX, as the page will more or less behave like an SPA, and thus the search index has to be built only once. |
I took the time and implemented instant loading as can be seen in the latest version of Works pretty well already and it's super fast! v5 will add instant loading as an experimental |
I had to look up what instant loading is, but now that I know: Sounds great! 👏🏻 |
@wilhelmer don’t really know what to call it. There’s this JavaScript library called Turbolinks which does something similar but that does sound very Wordpressy. |
Do you want tickets for v5 bugs yet? I only found two small problems so far:
|
@Stanzilla thanks for checking it out already. For now just post your findings here. If we hit beta / release candidate, we can open a separate issue and maybe project to keep track of things without flooding the issue tracker.
What do you mean exactly? It's dependent on the
Thanks for catching them. Typings are ongoing :-) The component union type must be put somewhere else, will fix the typings then. Maybe don't focus on the code base (e.g. typing errors) right now but on the functionality because I sometimes commit stuff that is not quite ready yet / needs work, but the branch is WIP anyway. How does the instant loading work for you? I think it works pretty great already, though a little jittery when skimming through the browser history. Still trying to map out how to smoothen things out. |
Alright! And I was getting some "app is not defined" errors before but I just checked again and they are gone, sorry! Functionality is pretty nice atm, I haven't checked which of my workarounds from v4 I can drop, I made some to workaround the collapse issue for examples. Also I edited the partial so I can have external links open in a new window instead, that currently causes a few JS errors in the console. Is that something you would like to support natively in the future? Maybe as a parameter from mkdocs.yml? |
The collapse issue (will) be fixed completely as we'll now listen on the
Good to know, will look into it. CMD + Click should not be intercepted but open in a new tab as expected.
Nope, we removed it for UX reasons. It's however super easy to add the behavior in v5 via custom JavaScript that runs automatically, probably something like: merge(load$, switch$)
.subscribe(document => {
document.querySelectorAll("a").forEach(el => {
el.setAttribute("target", "_blank")
})
}) ... whereas |
That's slightly less ugly than my
:D Oh and I had to add the webpack copy plugin back for a custom JS file. |
I moved everything that is unnecessary out of Webpack into the |
Just thought about the external links thing again, would still love to see that come back as an option because I'd still have to flag certain links with manual edits in the template for your JS solution to work properly. |
The only external links that are added directly through Material are those in the footer and the source link. The Navigation is entirely local, so it should open in the same window. Furthermore, opening something in a new window is bad UX, as it's not transparent to the user. For this reason I can definitely say it's not coming back, I'm sorry. |
Yeah I just want to open social links and the edit one in a new window |
Not-so-much that there'll be more time for coding, just that we can compensate you for your contributions. I don't expect more by donating, I already received everything I need! :) |
@wilhelmer @markallasread I started an Amazon wish list – in case somebody wants to give something back. 😊 |
@squidfunk the wish list link takes me to amazon.com...are you in the US? |
@outofphase nope, Germany. You're correct. I'll fix it and migrate it to Amazon Germany. |
Migrated the lis to my German account and fixed the link above, can you check again? |
Yes that's worked, although not surprisingly everything is now in German which made navigating through the Amazon maze a little tricky for me. I really hope that I haven't just started a 30 day free trial of Amazon Prime. With luck you should get the book by the XKCD guy on Weds. I think that one of the Amazon prompts was saying "buying from somewhere else?" which I should have clicked, but that also was in German so I wasn't sure. You should probably give guidance about that for non-German speakers. |
I started a migration guide for v5, documenting the changes that are necessary to the templates and partials if the user has overridden them in their build here. Those changes are crucial for the new (and more future-proof) application structure. I will also add another section on configuration changes and customization such as colors etc. In general the overall structure did not change much, especially custom CSS should continue to work in 99% of the cases. I'm also hoping to finish the missing features within the next days, so we can put out a fully working RC. Sorry for the delay, quite hard to find some spare time at the moment. |
For me, the build process changes were/are the biggest hurdle, might be worth mentioning as well! |
@Stanzilla What specifically would be worth mentioning? Would you mind writing down the hurdles you experienced? |
The move from webpack to the makefile, I have a few custom things in the webpack config and the new structure was a bit confusing to me, also probably less Windows friendly. I also sometimes have to npm clean before I can build because it does not see changes even though I did them |
If you could isolate what files do not get rebuilt when changed we can fix the Makefile |
I just remembered, webpack config changes. If I do build, change something webpack.config.ts and then build again, it does nothing. |
@Stanzilla should be fixed with 9b9527f – but I'm pretty sure that Webpack config changes are also not picked up on |
Small update: took the afternoon and finished the keyboard handlers (general and search-related) and copy-to-clipboard integration. Needs some cleanup (the main |
... and we're back to Webpack as of b486d0b. I ditched the whole Makefile-based approach. For a project the size of Material compatibility is an important issue and I ran into problems with asset versioning etc. where I would've had to build a lot of stuff from scratch. It just makes no sense. Sorry for any confusion this has caused with forks. |
Yay! |
Small facelifting of Admonitions in a018ed0: Before: After: |
Looks nice! |
Fixed a lot of stuff today including some long standing errors. @facelessuser you're the only one I know of who is running the dev build in production. Could I ask you to update to the latest version to see if something breaks? Bugs fixed in refactoring branch: Bugs fixed which are still in current
New features not in |
Yeah, I'll try it out and get back to you later today or tomorrow. |
@squidfunk, seems to be working for me. Nothing obvious seems broken. |
@wilhelmer I made some steps towards a solution for making localsearch work with v5 in fdffefd. It's now possible to pass a What remains is making the Thus, inlining the
|
Thanks for your effort! I created #1464 just while you typed this 😄 I hope we can continue the discussion there. I won't be able to do the coding myself, but my colleague will join in. |
Just released Material 5.0.0b1. See #1465. Would be awesome to get some feedback, especially on the brand new search. Please report any problems, issues or incompatibilities in the linked issue. |
Just released Material 5.0.0b2. See #1469. Again, would be great to get some feedback, and finally a new feature - instant loading! |
Much better than the other one. I love it! |
@mnogue it's only the default icon, though 😊Changeable with a single line of code. The official docs will however include the new logo I posted earlier. |
🎉Beta 3 just landed in #1483 and since we're feature complete, I'm closing this issue. I would encourage everybody to test the latest beta, as it's the last one before the final RC. There's still some cleaning up to do, but there's not much to change after beta 3. The more people test it, the earlier we can roll out a release candidate and finally get v5 out of the door! |
Description
The last major releases of Material for MkDocs were mainly issued for compatibility reasons. While version 2 and 3 were related to backward incompatible changes of MkDocs (0.17.1 and 1.0 respectively), version 4 was released due to backward incompatible changes related to users with Chinese system languages (#911). The next iteration, version 5, is a substantial rewrite of the underlying JavaScript functionality to a TypeScript and RxJS-based architecture. This will yield the following major benefits:
All features that are provided by the theme (e.g. the sidebars, tabs, search, etc.) will be observable by 3rd party JavaScript. This allows for very easy extension and customization. This will address issues like Add 'selected' as toc item state #1102 where users want to extend the functionality of the theme without re-compiling or forking it. Also, disabling functionality should be easier.
Improving search performance. Search will be moved to a web worker and exhibit better caching and re-building behavior. This will mitigate problems were the UI freezes due to large search indexes which pre-building on the server-side only partly solves. Furthermore, search will be re-architected to fit into the plugin concept introduced by MkDocs 1.x.
Color customization will be re-implemented using CSS variables. Changing the color to your custom brand colors will be even simpler and the theme will become smaller (as the palette CSS file will not be necessary anymore). Support for CSS variables is pretty great by now, but there are some browsers that don't support it, respectively IE 11, Opera mini, QQ browser and Baidu browser. These browsers will receive a (probably neutral) fallback color. If you must support those browsers, you can still extend the theme and customize the build will custom CSS colors as already described in the customization guide.
There might also be some slight face lifting, but the main aspects of Material 5 is the introduction of a more modern architecture. The rewrite will also make the theme testable, so unit tests can and will be written to ensure functionality.
I will document my progress here and there will be a beta phase similar to before the release of 1.0.0 (#46). Some lists with things that need to be done will follow.
Evaluate
Consider flexsearch as an alternative to lunr.jsTODOs
5.0
General
Functionality
General
<details>
/<summary>
functionality<details>
after child-anchor jump<details>
before printingScroll-related
Sidebars
Search
Persist search index in local storagesee Material 5.0.0 Beta 1 #1465 (comment)Compress search indexsee Material 5.0.0 Beta 1 #1465 (comment)Accessibility
Repository
Issues
background-color
definition on root (If you set either foreground or background color by default, please also set the other #1418)5.x
The text was updated successfully, but these errors were encountered: