Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RealEventSource lost control on Error #8463

Open
chinafzy opened this issue Jun 30, 2024 · 0 comments
Open

RealEventSource lost control on Error #8463

chinafzy opened this issue Jun 30, 2024 · 0 comments
Labels
bug Bug in existing code

Comments

@chinafzy
Copy link

As shown in the code snippet, if an Error (such as OutOfMemoryError or StackOverflowError, which are common) is thrown at line 78, the catch block at line 81 will not catch this Error, and neither the onFailure nor onClose hooks will be called. Consequently, the processing flow will terminate silently.
Therefore, it is recommended to catch Throwable instead.

okhttp_bug

@chinafzy chinafzy added the bug Bug in existing code label Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug in existing code
Projects
None yet
Development

No branches or pull requests

1 participant