Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnectionPool builder #7631

Closed
yschimke opened this issue Jan 4, 2023 · 1 comment
Closed

ConnectionPool builder #7631

yschimke opened this issue Jan 4, 2023 · 1 comment
Labels
enhancement Feature not a bug

Comments

@yschimke
Copy link
Collaborator

yschimke commented Jan 4, 2023

ConnectionPool is way more configurable (taskRunner + connection listener) and adding another public constructor is likely just going to become an n+1 treadmill.
@yschimke yschimke added the enhancement Feature not a bug label Jan 4, 2023
@yschimke yschimke mentioned this issue Jan 4, 2023
Merged
@swankjesse
Copy link
Collaborator

I’d prefer to avoid adding a builder. This is something you should configure at most once in any application.

@yschimke yschimke closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature not a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@swankjesse @yschimke