Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request cancellation requires consuming remaining bytes for HTTP/2 connections #4126

Closed
yschimke opened this issue Jul 7, 2018 · 3 comments
Closed

Request cancellation requires consuming remaining bytes for HTTP/2 connections #4126

yschimke opened this issue Jul 7, 2018 · 3 comments
Labels
bug Bug in existing code
Milestone
3.11

Comments

@yschimke
Copy link
Collaborator

yschimke commented Jul 7, 2018

To be filled in next week

We're not reading the full response body in the test app (i'm just using exoplayer and the OKHttp extension for it).

I modified the test in question to stop discarding the bytes on cancel and it fails with the exact error we're seeing in our application:

Split off #3915

cc @natez0r @dave-r12
@yschimke yschimke added this to the 3.12 milestone Jul 7, 2018
@yschimke
Copy link
Collaborator Author

yschimke commented Jul 9, 2018

related test PR - #4127

@yschimke yschimke added the bug Bug in existing code label Jul 13, 2018
@veang544
Copy link

Support

@swankjesse
Copy link
Collaborator

I believe the fix shipped with 3.11.

@swankjesse swankjesse modified the milestones: Backlog, 3.11 Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug in existing code
Projects
None yet
Milestone
3.11
Development

No branches or pull requests
3 participants
@swankjesse @yschimke @veang544