Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for SETTINGS #32

Closed
swankjesse opened this issue Sep 21, 2012 · 7 comments
Closed

Better support for SETTINGS #32

swankjesse opened this issue Sep 21, 2012 · 7 comments
Milestone

Comments

@swankjesse
Copy link
Collaborator

The spdy/2 spec wants us to store settings somewhere durable (like HTTP cookies) so we can honor each server's advice when we create new SPDY connections later.

Currently we aren't doing this. We may want to.

It's more interesting if we ever want to send SETTINGS frames, since then we'll be obligated to remember what the server told us, even if we aren't otherwise interested.

@jasnell
Copy link

jasnell commented May 21, 2013

SETTINGS persistence is currently considered "at risk" in the http/2 spec, so it's likely best to continue holding off on implementing support ;-)

@swankjesse
Copy link
Collaborator Author

Great, thanks for the heads up.

@swankjesse
Copy link
Collaborator Author

Closing for now. Will revisit when we start to build out HTTP/2.0 support.

@madongfly
Copy link

Can you consider this now?

We (gRPC-java) are going to use MAX_CONCURRENT_STREAMS (grpc/grpc-java#181), can we at least public the get/set method of Settings?

@swankjesse
Copy link
Collaborator Author

At the moment GRPC is using only a small part of OkHttp's codebase. And it's using code from our internal package, which means we don't promise API or binary compatibility between any releases.

I think our best next step is for GRPC to copy the relevant classes from OkHttp into GRPC. You can add whatever features you need, and we can avoid breaking you as we change our code.

I think GRPC should continue to use Okio, which is what makes it possible to build an HTTP/2 client without much code.

@swankjesse
Copy link
Collaborator Author

Also, if you do copy HTTP/2 code into GRPC, and implement a bunch of new stuff, there's nothing stopping us from folding those improvements back into OkHttp proper. But I think a library-dependency is a bad fit until we offer public APIs for low-level HTTP/2 operations. (Which we aren't planning!)

@louiscryan
Copy link

I guess another option on the table would be to provide a proguard stripped version of Netty that was GRPC-on-Android specific, no idea what that would end up looking like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants