Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back support for Thread name based exclusions #1339

Closed
pyricau opened this issue May 7, 2019 · 0 comments · Fixed by #1353
Closed

Add back support for Thread name based exclusions #1339

pyricau opened this issue May 7, 2019 · 0 comments · Fixed by #1353
Milestone
2.0-alpha-2

Comments

@pyricau
Copy link
Member

pyricau commented May 7, 2019

The new shortest path finding does not currently support thread name based exclusions, those are no-ops.
@pyricau pyricau added this to the 2.0 Next Release milestone May 7, 2019
pyricau added a commit that referenced this issue May 20, 2019
@pyricau
Thread name based exclusions
501b48e 
* Readded support for exclusions of local variable based on thread names
* Renamed ThreadExclusion to JavaLocalExclusion
* Fixed bug: KeyedWeakReference was not always ignored because its superclass is has a weakly reachable exclusion.
* Fixed bug: all root nodes had the same visit order as the first non root enqueued item, making it possible for a non root node to be dequeued before we're done with all roots.
* Redded gc root sorting
* Added tests to cover all uncovered bugs
* Added support for parsing StackFrameRecord

Fixes #1339
@pyricau pyricau mentioned this issue May 20, 2019
Merged
pyricau added a commit that referenced this issue May 20, 2019
@pyricau
Thread name based exclusions (#1353)
6c2ee60 
* Readded support for exclusions of local variable based on thread names
* Renamed ThreadExclusion to JavaLocalExclusion
* Fixed bug: KeyedWeakReference was not always ignored because its superclass is has a weakly reachable exclusion.
* Fixed bug: all root nodes had the same visit order as the first non root enqueued item, making it possible for a non root node to be dequeued before we're done with all roots.
* Redded gc root sorting
* Added tests to cover all uncovered bugs
* Added support for parsing StackFrameRecord

Fixes #1339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0-alpha-2
Development

Successfully merging a pull request may close this issue.

Thread name based exclusions square/leakcanary
1 participant
@pyricau