Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifying of new leaks vs existing leaks #1328

Closed
pyricau opened this issue May 2, 2019 · 0 comments · Fixed by #1334
Closed

Notifying of new leaks vs existing leaks #1328

pyricau opened this issue May 2, 2019 · 0 comments · Fixed by #1334
Milestone
2.0-alpha-2

Comments

@pyricau
Copy link
Member

pyricau commented May 2, 2019

Now that we have leak groups, we can determine at analysis time if any leak is new or we already had a group for it. We could show "new" vs "not new" in the UI and notifications, "new" meaning "all entries in that group came from the last analysis"

Thanks @tyvsmith for the idea.
@pyricau pyricau added this to the 2.0 Next Release milestone May 2, 2019
pyricau added a commit that referenced this issue May 5, 2019
@pyricau
Highlighting new leaks
dedd017 
New leaks are leaks that have a leak group that doesn't exist in any prior analysis.

* The notification now reports the count of leaks, with a split of new, known, and won't fix.
* The analysis success screen shows new leaks
* Moved description prefixes to be computed rather than inserted in the DB

Fixes #1328
@pyricau pyricau mentioned this issue May 5, 2019
Merged
pyricau added a commit that referenced this issue May 5, 2019
@pyricau
Highlighting new leaks (#1334)
f9a0518 
New leaks are leaks that have a leak group that doesn't exist in any prior analysis.

* The notification now reports the count of leaks, with a split of new, known, and won't fix.
* The analysis success screen shows new leaks
* Moved description prefixes to be computed rather than inserted in the DB

Fixes #1328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0-alpha-2
Development

Successfully merging a pull request may close this issue.

Highlighting new leaks square/leakcanary
1 participant
@pyricau