Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable LeakSentry, off in release buidls #1327

Closed
pyricau opened this issue May 2, 2019 · 0 comments · Fixed by #1332
Closed

Option to disable LeakSentry, off in release buidls #1327

pyricau opened this issue May 2, 2019 · 0 comments · Fixed by #1332
Milestone

Comments

@pyricau
Copy link
Member

pyricau commented May 2, 2019

Developers who watch custom objects have the RefWatcher in their production code. It's easy enough to separate it out and have a no-op in its place, but the other option is to add LeakSentry as a dependency (it's small enough). That being said, not everybody will want it turned on by default.

Let's add an option to enable / disable leak sentry reference retaining. By default it'll be on in debuggable builds and off otherwise.

@pyricau pyricau added this to the 2.0 Next Release milestone May 2, 2019
pyricau added a commit that referenced this issue May 4, 2019
LeakCanary has an enabled config option. Default is on in debug builds off in release builds.

Fixes #1327
pyricau added a commit that referenced this issue May 4, 2019
LeakCanary has an enabled config option. Default is on in debug builds off in release builds.

Fixes #1327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant